fix stack overflow by enum and cont issue #36163 #38093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I was just helping to debug :) r? @arielb1 |
arielb1
reviewed
Dec 1, 2016
| } | ||
| } | ||
| fn with_item_id_pushed<F>(&mut self, id: ast::NodeId, f: F, span: Span) | ||
| where F: Fn(&mut Self) | ||
| { | ||
| if self.opt_last_id.map_or(false, |last| last == id) { |
There was a problem hiding this comment.
This could be self.opt_last_id == Some(id), but what is this supposed to be doing?
arielb1
reviewed
Dec 1, 2016
| if self.idstack.iter().any(|&x| x == id) { | ||
| if self.detected_recursive_ids.contains(&id) { |
There was a problem hiding this comment.
nit: this could be if let Some(..) = self.detected_recursive_ids.replace(id).
|
I think you can skip the exponential worst-case by removing |
|
r+ with the "removing visit_expr" change if that works. |
… were skipped while checking for recursion.
mikhail-m1
force-pushed
the
stack-overflow
branch
from
2c72813
to
b8d8ab8
Compare
|
@arielb1 I've just tested it works, but I thought I tested it before. I also removed RefCell, hope you don't mind. |
bors
added a commit
that referenced
this pull request
Dec 5, 2016
fix stack overflow by enum and cont issue #36163 some paths were skipped while checking for recursion. I fixed bug reproduces on win64 cargo test. In previous PR #36458 time complexity was exponential in case of linked const values. Now it's linear. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some paths were skipped while checking for recursion.
I fixed bug reproduces on win64 cargo test. In previous PR #36458 time complexity was exponential in case of linked const values. Now it's linear.
r? @alexcrichton